Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83409?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/hatch/var/jinlon: Use display device type vs hardocded address
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83409/comment/f3cc808e_d9dcf627?usp... :
PS2, Line 7: mb/google/hatch/var/jinlon: Use display device type vs hardocded address
Suggestion:
```
Replace hard-coded address with device name
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83409?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief22928ea831d4cb5b483406ac388218a97ad98b
Gerrit-Change-Number: 83409
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:45:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No