John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42693 )
Change subject: soc/intel/tigerlake: Fix unresolved symbol CDW1 error ......................................................................
soc/intel/tigerlake: Fix unresolved symbol CDW1 error
The dmesg shows unresolved symbol CDW1 with AE_NOT_FOUND error after booting to kernel. Fix the error by properly creating the buffer field CDW1 to cover all errors scenarios.
BUG=b:140645231 TEST=Verified no AE_NOT_FOUND error related to _SB.OSC.CDW1.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ibfe677f87736ce1930e06b9cd649791977116012 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/42693/1
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index 2fda693..3f51ecc 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -159,13 +159,14 @@ * control of the respectively capabilities or features. */ Name (CTRL, 0) /* Control field value */ + CreateDWordField (Arg3, 0, CDW1) If (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) { - CreateDWordField(Arg3, 0, CDW1) - CreateDWordField(Arg3, 2, CDW3) + CreateDWordField (Arg3, 2, CDW3) CTRL = CDW3
If (Arg1 != REVISION_ID) { CDW1 |= UNRECOGNIZED_REVISION + Return (Arg3) } CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING | INTER_DOMAIN_USB4_INTERNET_PROTOCOL
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42693 )
Change subject: soc/intel/tigerlake: Fix unresolved symbol CDW1 error ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42693 )
Change subject: soc/intel/tigerlake: Fix unresolved symbol CDW1 error ......................................................................
soc/intel/tigerlake: Fix unresolved symbol CDW1 error
The dmesg shows unresolved symbol CDW1 with AE_NOT_FOUND error after booting to kernel. Fix the error by properly creating the buffer field CDW1 to cover all errors scenarios.
BUG=b:140645231 TEST=Verified no AE_NOT_FOUND error related to _SB.OSC.CDW1.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ibfe677f87736ce1930e06b9cd649791977116012 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42693 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index 2fda693..3f51ecc 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -159,13 +159,14 @@ * control of the respectively capabilities or features. */ Name (CTRL, 0) /* Control field value */ + CreateDWordField (Arg3, 0, CDW1) If (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) { - CreateDWordField(Arg3, 0, CDW1) - CreateDWordField(Arg3, 2, CDW3) + CreateDWordField (Arg3, 2, CDW3) CTRL = CDW3
If (Arg1 != REVISION_ID) { CDW1 |= UNRECOGNIZED_REVISION + Return (Arg3) } CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING | INTER_DOMAIN_USB4_INTERNET_PROTOCOL
-
John Zhao (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)