Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85712?usp=email )
Change subject: soc/intel/pantherlake: Add ACPI name for GSPI2 ......................................................................
soc/intel/pantherlake: Add ACPI name for GSPI2
This change adds the ACPI name "SPI2" for the GSPI2 device in the Panther Lake SOC.
Replace space with tab for PCI_DEVFN_GSPI2 macro.
w/o this patch:
[ERROR] Missing ACPI Name for PCI: 00:12.6 [ERROR] Missing ACPI Name for PCI: 00:12.6
w/ this patch:
No error
Change-Id: I404ddb893b82836e06d0f52a6d6f2aff2273d8c6 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/pantherlake/chip.c M src/soc/intel/pantherlake/include/soc/pci_devs.h 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/85712/1
diff --git a/src/soc/intel/pantherlake/chip.c b/src/soc/intel/pantherlake/chip.c index 2c79fe7..5fe2a37 100644 --- a/src/soc/intel/pantherlake/chip.c +++ b/src/soc/intel/pantherlake/chip.c @@ -86,6 +86,7 @@ case PCI_DEVFN_NPU: return "NPU"; case PCI_DEVFN_IPU: return "IPU0"; case PCI_DEVFN_ISH: return "ISHB"; + case PCI_DEVFN_GSPI2: return "SPI2"; case PCI_DEVFN_XHCI: return "XHCI"; case PCI_DEVFN_SRAM: return "SRAM"; case PCI_DEVFN_I2C0: return "I2C0"; diff --git a/src/soc/intel/pantherlake/include/soc/pci_devs.h b/src/soc/intel/pantherlake/include/soc/pci_devs.h index bff5bd3..5c74b6d 100644 --- a/src/soc/intel/pantherlake/include/soc/pci_devs.h +++ b/src/soc/intel/pantherlake/include/soc/pci_devs.h @@ -95,7 +95,7 @@ #define PCI_DEVFN_ISH _PCI_DEVFN(ISH, 0) #define PCI_DEVFN_P2SB2 _PCI_DEVFN(ISH, 1) #define PCI_DEVFN_IEH_1 _PCI_DEVFN(ISH, 3) -#define PCI_DEVFN_GSPI2 _PCI_DEVFN(ISH, 6) +#define PCI_DEVFN_GSPI2 _PCI_DEVFN(ISH, 6) #define PCI_DEV_ISH _PCI_DEV(ISH, 0) #define PCI_DEV_P2SB2 _PCI_DEV(ISH, 1) #define PCI_DEV_IEH_1 _PCI_DEV(ISH, 3)
-
Subrata Banik (Code Review)