Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/83646?usp=email )
Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/83646/comment/0c3aaa76_5497c0ab?usp... :
PS5, Line 8: #if CONFIG(BOARD_GOOGLE_MARKARTH) || CONFIG(BOARD_GOOGLE_WINTERHOLD)
I don't see a need to use a preprocessor define here. […]
Done
https://review.coreboot.org/c/coreboot/+/83646/comment/e4aaf016_9158bbde?usp... :
PS5, Line 38: #if CONFIG(BOARD_GOOGLE_MARKARTH) || CONFIG(BOARD_GOOGLE_WINTERHOLD)
no preprocessor define - `if (CONFIG(BOARD_GOOGLE_MARKARTH) || CONFIG(BOARD_GOOGLE_WINTERHOLD)) {... […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83646?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Gerrit-Change-Number: 83646
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 08:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com