[M] Change in coreboot[main]: mb/google/skyrim: Combine the function port_descriptors for variants

[Matt DeVillier (Code Review)]

Attention is currently required from: Bao Zheng, Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Paul Menzel, Zheng Bao.

Matt DeVillier has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/83646?usp=email )

Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................

Patch Set 5:

(2 comments)

File src/mainboard/google/skyrim/variants/baseboard/port_descriptors.c:

https://review.coreboot.org/c/coreboot/+/83646/comment/f6339a6e_b8f295d5?usp... :
PS5, Line 8: #if CONFIG(BOARD_GOOGLE_MARKARTH) || CONFIG(BOARD_GOOGLE_WINTERHOLD)
I don't see a need to use a preprocessor define here.

I'd also drop the enum and just create another DXIO descriptor for WLAN+NVME, and select that below vs replacing, but that's just me

https://review.coreboot.org/c/coreboot/+/83646/comment/b29599b2_69b5fd92?usp... :
PS5, Line 38: #if CONFIG(BOARD_GOOGLE_MARKARTH) || CONFIG(BOARD_GOOGLE_WINTERHOLD)
no preprocessor define - `if (CONFIG(BOARD_GOOGLE_MARKARTH) || CONFIG(BOARD_GOOGLE_WINTERHOLD)) {...}` will do just fine.

You can also simplify it as:

```
if (MK or WH) {
  if (!EMMC_GPIO) {
    printk(BIOS_DEBUG, "Enabling NVMe.\n");
    emmc_dxio_descriptors[EMMC_DXIO_STORAGE] = (fsp_dxio_descriptor)NVME_DXIO_DESCRIPTOR;
  } else {
    printk(BIOS_DEBUG, "Defaulting to eMMC.\n");
  }
  *dxio_descriptor = emmc_dxio_descriptors;
  *num = ARRAY_SIZE(emmc_dxio_descriptors);
} else {
  *dxio_descriptor = skyrim_mdn_dxio_descriptors;
  *num = ARRAY_SIZE(skyrim_mdn_dxio_descriptors);
}
```