Attention is currently required from: Kevin Chang, Tim Wawrzynczak, Zhuohao Lee.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50872 )
Change subject: mb/google/volteer/var/lindar: Add custom SAR values for Lindar/Lillipup
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I think it is weird to use the TABLETMODE_ENABLED in the FW_CONFIG to switch the SAR table dynamical […]
It can be done but in this case the FW_CONFIG field will just be used by Lillipup/Lindar, though. IMHO, the differentiation can be done via,
1. ConfigId -- this will be messy due to the number of ConfigIds.
2. FW_CONFIG -- we will need to concern about the extendability. Say, if later on we need to add "global" FW_CONFIG field (due to refactoring or other reasons) we have to watch out not to step on this.
3. Make use of well-known information -- in this case since only Lillipup support tablet mode it can be used to tell them apart.
4. Maybe other better ways?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe829062033ba8246b9d9550cdcdc360f5f67dd3
Gerrit-Change-Number: 50872
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Mon, 22 Feb 2021 05:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: YH Lin
yueherngl@google.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment