Attention is currently required from: Anil Kumar K, Tim Wawrzynczak, Paul Menzel, Sridhar Siricilla, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62192 )
Change subject: soc/intel/common: Retry END_OF_POST command
......................................................................
Patch Set 12:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62192/comment/08d262c4_631094e4
PS12, Line 11: max 3 times
ME BWG spec recommends only 3 times, hence I'm retrying thrice (including 1st attempt)
Well, your commit message says something different and even your comment is not consistent :P
*re*tries the EOP command max 3 times == *re*trying thrice != including 1st attempt == trying once, *re*trying twice
*re*trying means try *again*. However, you cannot try *again* if you haven't tried once before. So, actually you're trying once and retrying twice *or* just trying thrice.
(Sorry for nitpicking ;D)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62192
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683
Gerrit-Change-Number: 62192
Gerrit-PatchSet: 12
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.nest@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 18:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment