[L] Change in coreboot[master]: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Kapil Porwal, Nick Vaccaro, Paul Menzel.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )

Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer
......................................................................

Patch Set 4:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76921/comment/584658e2_7ba5a161 :
PS3, Line 15: bootloader
> Wrong term?

Acknowledged

https://review.coreboot.org/c/coreboot/+/76921/comment/e9b19b26_bec97646 :
PS3, Line 18: It also adds a
            : new config (BMP_LOGO_TO_GOP_BLT) to ensure backward compatibility with
            : older generation FSP.
> Can’t this (the FSP version) be detected at runtime?

I don't believe such a decision can be made dynamic because not all platform might like to enable pre-boot splash screen feature hence, its good to leave that flexibility in hand of the platform owner to choose if pre-boot splash screen is something that they wish to opt.

From SOC side, this is a feature which platform owner can enable/disable hence, the choice has to be the there.

File src/drivers/intel/fsp2_0/fsp_gop_blt.c:

PS3:
> How special is `efi_bmp_image_header`? Otherwise most of these functions (check, if the image is valid) could be common code in coreboot.

not very big like 54 bytes in size plus we need efi_bmp_color_map and efi_graphics_output_blt_pixel.

hence, better we leverage those from EDk2 headers