Attention is currently required from: Chen-Tsung Hsieh, Tao Xia, Xuxin Xiong.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51853 )
Change subject: mb/google/kukui: fix the issue of getting error panel_id
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51853/comment/ff601e8f_a947d5ca
PS3, Line 126: TODO
I wonder if we can do this now. If this issue is urgent, we can fix it in kukui branch first with this workaround.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63e0c8a2719462a9b979afe52a27c78b9fc804e8
Gerrit-Change-Number: 51853
Gerrit-PatchSet: 3
Gerrit-Owner: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Mar 2021 09:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment