Attention is currently required from: Anil Kumar K, Vinay Kumar, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62630 )
Change subject: mb/google/brya: Disable c1-state auto demotion for Brya & Brask
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62630/comment/3490cc89_7b44b9e5
PS5, Line 13: disabling this feature results in 110 mW power savings
Hi Subrata,
Yes your observation from previous generations is correct. But in ADLP this feature is not working as expected and hence needs to be disabled to avoid PnP impact. We found that C1stateAutodemotion feature is not supported for ADLP SKUs, so default option is for it to be disabled. Hence keeping it disabled.
BR,
-Vinay
Thanks Vinay for sharing the details, Can you please update the commit msg to reflect "C1stateAutodemotion" is not applicable for ADL and future generation SoC platform ?
Commit Message:
https://review.coreboot.org/c/coreboot/+/62630/comment/8c1aefaa_b4f54331
PS9, Line 9: c1
C1
https://review.coreboot.org/c/coreboot/+/62630/comment/30ec8b44_3f1e1f91
PS9, Line 9: c1
C1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41eea916cdfe4a86e4d263e3191f5cb40fa33a90
Gerrit-Change-Number: 62630
Gerrit-PatchSet: 9
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 09 Mar 2022 08:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment