Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57805 )
Change subject: soc/intel/common/../cse: Perform D0I3 bit reset/set prior sending EOP
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57805/comment/cae73dd4_e9d62ab5
PS3, Line 10: Incase CSE is in Dev Idle state
: meaning D0I3 bit is set then ensures resetting this bit, prior to
: sending
: EOP command.
There's several minor things about this sentence. I'd rephrase it as follows:
In case CSE is in Dev Idle state (which means D0I3 bit is set), reset this bit before sending EOP command.
https://review.coreboot.org/c/coreboot/+/57805/comment/98b7d91d_a3e99666
PS3, Line 16: evitable
nit: `avoidable` is more common
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae1bc52e94b08f97004424ea0c147d6da8aca6e2
Gerrit-Change-Number: 57805
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 26 Sep 2021 11:23:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment