[S] Change in coreboot[master]: mb/google/myst: Update PCIe romstage gpios - coreboot-gerrit

8 Jun 2023


      Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Martin Roth, Tim Van Patten.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75699?usp=email )
Change subject: mb/google/myst: Update PCIe romstage gpios
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75699/comment/a35bf24b_76bfd221 :
PS1, Line 203: 	/* SSD_AUX_RESET */
...
Recommend doing the same for SD as well since that also needs to be brought out of reset before PCIe […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75699?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24ad6c1addedb414afade2512b6628022d000a47
Gerrit-Change-Number: 75699
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 21:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment