Change in coreboot[master]: mb/intel/tglrvp : Add ACPI support for CNVi
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37887 ) Change subject: mb/intel/tglrvp : Add ACPI support for CNVi ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/37887/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/acpi/cnvi.asl: PS3:
some of method is using GPIO which is board specific(SBTE, GBTE) […] Nothing in this patch is really using those methods. Are those even required?
-- To view, visit https://review.coreboot.org/c/coreboot/+/37887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66091374f8ebcb06457296252c9a8924734a7fa5 Gerrit-Change-Number: 37887 Gerrit-PatchSet: 3 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com> Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.corp-partner.google.com> Gerrit-Comment-Date: Tue, 07 Jan 2020 04:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim@intel.com> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment
participants (1)
-
Furquan Shaikh (Code Review)