[M] Change in coreboot[main]: region: Turn region_end() into an inclusive region_last() - coreboot-gerrit

20 Jun 2024


      Attention is currently required from: Jakub Czapiga, Jérémy Compostella, Nico Huber, Werner Zeh.
Julius Werner has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email )
Change subject: region: Turn region_end() into an inclusive region_last()
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/commonlib/region.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/809fc0ef_3341705b?usp... :
PS5, Line 16: 	if (region_last(c) < region_offset(p))
...
Restored the original check. […]
Yeah let's just take this overlap check out then when the API already guarantees that regions cannot overlap.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79946?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4bd6eced638745b7e845504da74542e4220554a
Gerrit-Change-Number: 79946
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Jakub Czapiga czapiga@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 20 Jun 2024 21:53:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Julius Werner jwerner@chromium.org