Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36036 )
Change subject: nb/intel/raminit: Change the output verbosity of timings ......................................................................
nb/intel/raminit: Change the output verbosity of timings
This decreases the output verbosity of RAM_DEBUG to be useful.
Change-Id: I9fa681303da0e063dd2ca789d7711151b2365f16 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/36036/1
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index b9d407a..75be572 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -1576,14 +1576,14 @@ static void dump_timings(struct raminfo *info) { int channel, slot, rank, lane, i; - printk(RAM_DEBUG, "Timings:\n"); + printk(RAM_SPEW, "Timings:\n"); FOR_POPULATED_RANKS { - printk(RAM_DEBUG, "channel %d, slot %d, rank %d\n", channel, + printk(RAM_SPEW, "channel %d, slot %d, rank %d\n", channel, slot, rank); for (lane = 0; lane < 9; lane++) { - printk(RAM_DEBUG, "lane %d: ", lane); + printk(RAM_SPEW, "lane %d: ", lane); for (i = 0; i < 4; i++) { - printk(RAM_DEBUG, "%x (%x) ", + printk(RAM_SPEW, "%x (%x) ", read_500(info, channel, get_timing_register_addr (lane, i, slot, rank), @@ -1592,12 +1592,12 @@ lane_timings[i][channel][slot][rank] [lane]); } - printk(RAM_DEBUG, "\n"); + printk(RAM_SPEW, "\n"); } } - printk(RAM_DEBUG, "[178] = %x (%x)\n", read_1d0(0x178, 7), + printk(RAM_SPEW, "[178] = %x (%x)\n", read_1d0(0x178, 7), info->training.reg_178); - printk(RAM_DEBUG, "[10b] = %x (%x)\n", read_1d0(0x10b, 6), + printk(RAM_SPEW, "[10b] = %x (%x)\n", read_1d0(0x10b, 6), info->training.reg_10b); }
@@ -4011,19 +4011,19 @@ int j; if (s3resume && info.cached_training) { restore_274265(&info); - printk(RAM_DEBUG, "reg2ca9_bit0 = %x\n", + printk(RAM_SPEW, "reg2ca9_bit0 = %x\n", info.cached_training->reg2ca9_bit0); for (i = 0; i < 2; i++) for (j = 0; j < 3; j++) - printk(RAM_DEBUG, "reg274265[%d][%d] = %x\n", + printk(RAM_SPEW, "reg274265[%d][%d] = %x\n", i, j, info.cached_training->reg274265[i][j]); } else { set_274265(&info); - printk(RAM_DEBUG, "reg2ca9_bit0 = %x\n", + printk(RAM_SPEW, "reg2ca9_bit0 = %x\n", info.training.reg2ca9_bit0); for (i = 0; i < 2; i++) for (j = 0; j < 3; j++) - printk(RAM_DEBUG, "reg274265[%d][%d] = %x\n", + printk(RAM_SPEW, "reg274265[%d][%d] = %x\n", i, j, info.training.reg274265[i][j]); }
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36036 )
Change subject: nb/intel/raminit: Change the output verbosity of timings ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36036/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36036/1//COMMIT_MSG@7 PS1, Line 7: intel/ intel/nehalem/raminit
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36036
to look at the new patch set (#2).
Change subject: nb/intel/nehalem: Change the output verbosity of raminit timings ......................................................................
nb/intel/nehalem: Change the output verbosity of raminit timings
This decreases the output verbosity of RAM_DEBUG to be useful.
Change-Id: I9fa681303da0e063dd2ca789d7711151b2365f16 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/36036/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36036 )
Change subject: nb/intel/nehalem: Change the output verbosity of raminit timings ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36036/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36036/1//COMMIT_MSG@7 PS1, Line 7: intel/
intel/nehalem/raminit
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36036 )
Change subject: nb/intel/nehalem: Change the output verbosity of raminit timings ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36036 )
Change subject: nb/intel/nehalem: Change the output verbosity of raminit timings ......................................................................
nb/intel/nehalem: Change the output verbosity of raminit timings
This decreases the output verbosity of RAM_DEBUG to be useful.
Change-Id: I9fa681303da0e063dd2ca789d7711151b2365f16 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36036 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 11 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index b9d407a..75be572 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -1576,14 +1576,14 @@ static void dump_timings(struct raminfo *info) { int channel, slot, rank, lane, i; - printk(RAM_DEBUG, "Timings:\n"); + printk(RAM_SPEW, "Timings:\n"); FOR_POPULATED_RANKS { - printk(RAM_DEBUG, "channel %d, slot %d, rank %d\n", channel, + printk(RAM_SPEW, "channel %d, slot %d, rank %d\n", channel, slot, rank); for (lane = 0; lane < 9; lane++) { - printk(RAM_DEBUG, "lane %d: ", lane); + printk(RAM_SPEW, "lane %d: ", lane); for (i = 0; i < 4; i++) { - printk(RAM_DEBUG, "%x (%x) ", + printk(RAM_SPEW, "%x (%x) ", read_500(info, channel, get_timing_register_addr (lane, i, slot, rank), @@ -1592,12 +1592,12 @@ lane_timings[i][channel][slot][rank] [lane]); } - printk(RAM_DEBUG, "\n"); + printk(RAM_SPEW, "\n"); } } - printk(RAM_DEBUG, "[178] = %x (%x)\n", read_1d0(0x178, 7), + printk(RAM_SPEW, "[178] = %x (%x)\n", read_1d0(0x178, 7), info->training.reg_178); - printk(RAM_DEBUG, "[10b] = %x (%x)\n", read_1d0(0x10b, 6), + printk(RAM_SPEW, "[10b] = %x (%x)\n", read_1d0(0x10b, 6), info->training.reg_10b); }
@@ -4011,19 +4011,19 @@ int j; if (s3resume && info.cached_training) { restore_274265(&info); - printk(RAM_DEBUG, "reg2ca9_bit0 = %x\n", + printk(RAM_SPEW, "reg2ca9_bit0 = %x\n", info.cached_training->reg2ca9_bit0); for (i = 0; i < 2; i++) for (j = 0; j < 3; j++) - printk(RAM_DEBUG, "reg274265[%d][%d] = %x\n", + printk(RAM_SPEW, "reg274265[%d][%d] = %x\n", i, j, info.cached_training->reg274265[i][j]); } else { set_274265(&info); - printk(RAM_DEBUG, "reg2ca9_bit0 = %x\n", + printk(RAM_SPEW, "reg2ca9_bit0 = %x\n", info.training.reg2ca9_bit0); for (i = 0; i < 2; i++) for (j = 0; j < 3; j++) - printk(RAM_DEBUG, "reg274265[%d][%d] = %x\n", + printk(RAM_SPEW, "reg274265[%d][%d] = %x\n", i, j, info.training.reg274265[i][j]); }
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)