Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO config
......................................................................
Patch Set 16:
This CL should really be split into 4 changes:
a) Changes for GPP_* and PMC_GPP_* that are done in gpio.c(soc_pmc_gpio_routes), gpio_soc_defs.h(GPP_* definitions) and pmc.h -- This is really fixing the GPIO group mapping to GPE.
b) Changes for matching GPIO community/group mapping in coreboot with that of the latest kernel driver -- This should include changes in gpio.asl to add GCM0, GCM1, GCM4, GCM5 and the changes in GADD. Changes in gpio.c. Changes in gpio.h. Changes in gpio_defs.h. Changes in gpio_soc_defs.h except the pinmux macros.
c) Changes for adding ASL routines for GPIO(GTXS, STXS, CTXS) and updating GRXS.
d) Changes for pinmux -- Ideally I don't think this is required. But, if we do, then this should be a separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa
Gerrit-Change-Number: 37427
Gerrit-PatchSet: 16
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jan 2020 12:45:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment