Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Martin L Roth, Saurabh Mishra.
Nico Huber has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional ......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS4:
Let's keep this comment unresolved. […]
It's allowed to be empty, though.
Overall, I think we can live with a little uncertainty about the environment that triggers the issue. Just the commit message should be updated, I'll comment there.
Commit Message:
https://review.coreboot.org/c/coreboot/+/83887/comment/50174f1a_fe2dc72f?usp... : PS6, Line 22: the Makefile from breaking under the specified conditions. The `-c: option requires an argument` is nothing new and expected behavior. The problem rather seems to be that make executes a shell with an empty line (after processing the `$(if )`).
Please state instead that this change works around an issue in a particular environment. (And please consider reporting the issue upstream for your environment. Other projects may have similar makefile constructs, and they won't have to investigate / work around this if it's fixed upstream.)
-
Nico Huber (Code Review)