Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41062 )
Change subject: soc/intel/jasperlake: Update FiVR UPDs for JSL. ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41062/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41062/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/jasperlake: Update FiVR UPDs for JSL. Please remove the trailing period/dot from the git commit message summary.
https://review.coreboot.org/c/coreboot/+/41062/3//COMMIT_MSG@8 PS3, Line 8: What does this fix/improve? Describe, what FiVR is, and where you got the correct values from.
https://review.coreboot.org/c/coreboot/+/41062/3/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41062/3/src/soc/intel/jasperlake/fs... PS3, Line 150: /* Fivr */ Add blank line above?
-
Paul Menzel (Code Review)