Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62863 )
Change subject: soc/amd/sabrina: Add counter initializers
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62863/comment/5ee4c273_bfd29b7a
PS5, Line 10: functions
nit: newline
Ack
File src/soc/amd/sabrina/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/62863/comment/61735de3_f8b73b61
PS5, Line 50: fsp_dxio
Maybe set to NULL too?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d4f5b1124d4017b04bcaf7044216fd696dce63d
Gerrit-Change-Number: 62863
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 16 Mar 2022 15:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment