Attention is currently required from: Jakub Czapiga, Patrick Rudolph, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62181 )
Change subject: src/device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62181/comment/01d90110_0ff83748
PS4, Line 9: While on it, fix SPD_DDR4_DIMM_TYPE_72B_SO_RDIMM and SPD_DDR4_DIMM_TYPE_72B_SO_UDIMM values
: respectively to 0x08 and 0x09.
Please do this in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621
Gerrit-Change-Number: 62181
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 07 Mar 2022 16:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment