Attention is currently required from: Wonkyu Kim, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 )
Change subject: intel/common/../systemagent: Enable MCHBAR in bootblock ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63615/comment/41e0cd5f_fe1ced2e PS4, Line 9: Meteorlake Meteor Lake
https://review.coreboot.org/c/coreboot/+/63615/comment/ab7fcd53_6a3a2f01 PS4, Line 11: enabling enable
https://review.coreboot.org/c/coreboot/+/63615/comment/c54440ea_4df5c464 PS4, Line 10: As there is no harm to enable : MCHBAR from bootblock even in existing plaforms So the benefit is code unification? To my understanding the bootblock really should be as small as possible, so probably more advantages should be mentioned.
https://review.coreboot.org/c/coreboot/+/63615/comment/1c949c21_b6e65e7a PS4, Line 13: Don’t you need to remove also code from the other platforms doing this in romstage?
-
Paul Menzel (Code Review)