Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33759 )
Change subject: soc/amd/picasso: Create a hybrid romstage to begin in DRAM ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... File src/soc/amd/picasso/reset_vector.S:
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 135: */
No such file? Why near stacktop when you have . […]
Got out of sync when splitting. Will be N/A in a moment.
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 142: sub $8, %esp
Looks strange, %esp gets aligned again before next call.
Done
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 144: jmp _romstage_in_ram_continue
You could possibly call car_stage_entry here with timestamp and bist as parameters.
Ah, yeah. I realized that reading your comment in the x86 file about the code "reducing".
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 149: _start:
Changing semantics of _start? Used to be protected mode, now realmode, and I don't see what it is us […]
In new PS it should be the only _start.
-
Marshall Dawson (Code Review)