Attention is currently required from: Bob Moragues, Nick Vaccaro, Paul Menzel, Sumeet R Pawnikar.
Karthik Ramasubramanian has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83755?usp=email )
Change subject: mb/google/brox: Tune Touchpad I2C parameters
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83755/comment/3cf82521_ebe23108?usp... :
PS1, Line 9: that it meets the
: I2C fast mode specification
What does it require?
Done
https://review.coreboot.org/c/coreboot/+/83755/comment/9da0babb_a112a0b0?usp... :
PS1, Line 13: BIOS
firmware
Done
https://review.coreboot.org/c/coreboot/+/83755/comment/0e216b3d_c7c3540e?usp... :
PS1, Line 13: Confirm the I2C bus
: frequency, rise and fall times meet the specification.
Please list the measured values.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83755?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0006bfb9bb5839ffa1248d9f2ea055160ed0936e
Gerrit-Change-Number: 83755
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 06 Aug 2024 02:42:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org