[S] Change in coreboot[master]: device: Correct D3Cold Kconfig option - coreboot-gerrit

12 Apr 2023


      Attention is currently required from: Sean Rhodes, Nico Huber, Maximilian Brune.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74328 )
Change subject: device: Correct D3Cold Kconfig option
......................................................................
Patch Set 4:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/74328/comment/0f7ed0a1_51e27759 
PS2, Line 1007: config D3COLD_SUPPORT
...
can we drop the DT option for S0IX then (preferably in another patch)?
We had a discussion about that on IRC today, and it's still ongoing it seems. But in any case, using Kconfig for this is the wrong way I think.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bdb6589e98ac81d0ce25df52fb916b5c2fd0157
Gerrit-Change-Number: 74328
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 14:27:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Sean Rhodes sean@starlabs.systems
Comment-In-Reply-To: Maximilian Brune maximilian.brune@9elements.com
Gerrit-MessageType: comment