Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 )
Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/60379/comment/a275877c_8c359f65 PS2, Line 25: def_bool y
default n here?
Looking at other mainboard Kconfig, it appear to me that we always had a if clause to guard this Board Specific Kconfig selection. Hence, I have kept it in that way.
I understood the changes that you are suggesting, will wait for more feedback if we want to pursue the same.
https://review.coreboot.org/c/coreboot/+/60379/comment/c19a87e6_810ab740 PS2, Line 60:
add if BOARD_GOOGLE_BRYA_COMMON should be fine.
Ideally we wish to guard BOARD_GOOGLE_BRYA_COMMON (now BOARD_SPECIFIC_OPTIONS) using an if clause, I don't think we can move it later. But as I have mentioned, will wait for open feedback to see if thats the correct way to do. I have just follow the way its been done for other Kconfigs.
-
Subrata Banik (Code Review)