Attention is currently required from: Lance Zhao, Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Wisley Chen.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65611 )
Change subject: drivers/intel/dptf: Add multiple fan support under dptf
......................................................................
Patch Set 7:
(1 comment)
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/65611/comment/ed44511c_132f9900
PS6, Line 367: dptf_write_scope(participant);
:
: /* _FPS - Fan Performance States */
: acpigen_write_name("_FPS");
I think this is a bit much; the function name says "verify", but this writes out some AML, I think i […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96ead90e3b805bd20de03e4bef4fa4b9fbaaaedd
Gerrit-Change-Number: 65611
Gerrit-PatchSet: 7
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 01 Sep 2022 17:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment