Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83599?usp=email )
Change subject: gma: Re-structure TC port types ......................................................................
Patch Set 1:
(1 comment)
File common/hw-gfx-gma-config_helpers.adb:
https://review.coreboot.org/c/libgfxinit/+/83599/comment/2c237208_e29d5715?u... : PS1, Line 68: : when DP_TC1 | HDMI_TC1 | USBC1 => DDI_TC3, : when DP_TC2 | HDMI_TC2 | USBC2 => DDI_TC4, : when DP_TC3 | HDMI_TC3 | USBC3 => DDI_TC5, : when DP_TC4 | HDMI_TC4 | USBC4 => DDI_TC6,
ADL-P (XeLPD) doesn't even have TC5 .. TC6 so it definitely feels wrong. […]
Yes, the TGL PRM seems actually the only source that talks about 6 TC ports / register sets. I guess they just wanted to be prepared. Now I'm wondering if it's wise to keep the additional register definitions in the TGL code. I guess we'll see during review.