Attention is currently required from: Tim Wawrzynczak, YH Lin.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56754 )
Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/taeko/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125521):
https://review.coreboot.org/c/coreboot/+/56754/comment/08fc579c_8b93b1d5
PS2, Line 219: }
adding a line without newline at end of file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2
Gerrit-Change-Number: 56754
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Mon, 02 Aug 2021 05:34:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment