Attention is currently required from: Anand Vaikar, Felix Held, Paul Menzel.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80701?usp=email )
Change subject: soc/amd/glinda: Update GPP_CLK_OUTPUT_AVAILABLE to 7
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80701/comment/35a6384a_74892f2f :
PS1, Line 7: Update GPP_CLK_OUTPUT_AVAILABLE
i'd say that the 7 is the only relevant number here. […]
Done
https://review.coreboot.org/c/coreboot/+/80701/comment/2931a368_8c7db043 :
PS1, Line 10: Reference (PPR) (#57254), table 230.
or just refer to the table by its name "GPP ClkREQB Mapping"
Done
Patchset:
PS1:
i'd guess that in some version there were a few more tables added, so the numbers shifted
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80701?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26e9dea58b2ddf5cbedbcccb8bcbc5f9efab3165
Gerrit-Change-Number: 80701
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 23 Feb 2024 07:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment