Attention is currently required from: Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51804 )
Change subject: include/assert.h: Use mock_assert() for ENV_TEST targets ......................................................................
Patch Set 2:
(2 comments)
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/51804/comment/588a3f3b_e4d43bcb PS1, Line 12: #include <tests/test.h>
Probably better to just unconditionally (re-)define the prototype for mock_assert() rather than cond […]
Definition of mock_asert() should not change so it seems to be good idea. Done :)
https://review.coreboot.org/c/coreboot/+/51804/comment/83d71c98_0f392cac PS1, Line 67: #define assert(statement) mock_assert(statement, #statement, __FILE__, __LINE__)
Please add this to all forms of assert (e.g. […]
ASSERT(), ASSERT_MSG() and BUG() have different input parameters. I do not think, that we should add another macro containing ENV_TEST and FATAL_ASSERTS. Only FATAL_ASSERTS part does not change, but ENV_TEST part is different in each macro.
-
Jakub Czapiga (Code Review)