Hello Julius Werner, Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40241
to review the following change.
Change subject: [TEST] dead code in the bootblock? how does the error look like? ......................................................................
[TEST] dead code in the bootblock? how does the error look like?
Change-Id: Ib3fab91af136f874843bc59a9824e45bf873f6c8 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/lib/bootblock.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/40241/1
diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c index 565d619..a7cccb6 100644 --- a/src/lib/bootblock.c +++ b/src/lib/bootblock.c @@ -10,6 +10,7 @@ #include <program_loading.h> #include <symbols.h> #include <timestamp.h> +#include <assert.h>
DECLARE_OPTIONAL_REGION(timestamp);
@@ -60,6 +61,8 @@
timestamp_add_now(TS_END_BOOTBLOCK);
+ dead_code(); + run_romstage(); }
Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40241 )
Change subject: [TEST] dead code in the bootblock? how does the error look like? ......................................................................
Abandoned
it did its job, error looks good