Attention is currently required from: Jeff Daly, Tarun Tuli, Subrata Banik, Jonathan Zhang, Johnny Lin, Christian Walter, Kapil Porwal, Vanessa Eusebio, Arthur Heymans, Lean Sheng Tan, Werner Zeh, Tim Chu.
Hello build bot (Jenkins), Jeff Daly, Jonathan Zhang, Sean Rhodes, Tarun Tuli, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74760
to look at the new patch set (#5).
Change subject: soc/intel: Don't report _S1 state when unsupported
......................................................................
soc/intel: Don't report _S1 state when unsupported
Since skylake Intel hardware does not support this sleep state. Trying
to do enter it results in a system hang on at least
Alderlake (prodrive/atlas).
CONFIG_SOC_INTEL_COMMON_BLOCK_PMC is a good proxy whether devices
support 'skylake style' PMC PCI device for ACPI registers.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz
Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da
---
M src/Kconfig
M src/soc/intel/common/block/pmc/Kconfig
M src/southbridge/intel/common/acpi/sleepstates.asl
3 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/74760/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da
Gerrit-Change-Number: 74760
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-MessageType: newpatchset