Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34112 )
Change subject: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34112/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34112/3//COMMIT_MSG@9 PS3, Line 9: Also Enables qualcomm/ipq_806x monotonic timer. Better move into a separate follow-up patch in case something is wrong with the implementation?
https://review.coreboot.org/c/coreboot/+/34112/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/34112/3/src/Kconfig@509 PS3, Line 509: default
Hmm... no? I don't know what you would want this to look like.
I guess he meant
depends on !NO_MONOTONIC_TIMER
and that would remove the
# HAVE_MONOTONIC_TIMER is not set
from .config files. Same effect would have a single default line
default y if !ARCH_X86 && !NO_MONOTONIC_TIMER
https://review.coreboot.org/c/coreboot/+/34112/3/src/cpu/allwinner/a10/Kconf... File src/cpu/allwinner/a10/Kconfig:
https://review.coreboot.org/c/coreboot/+/34112/3/src/cpu/allwinner/a10/Kconf... PS3, Line 13: select NO_MONOTONIC_TIMER
Did you see the "implementation" file removed here.
There is a patch on Gerrit dropping the whole port. We were only waiting for coreboot 4.10...
-
Nico Huber (Code Review)