Change in coreboot[master]: mb/google/dedede: add mainboard_smi_espi_handler for dedede.

[Kane Chen (Code Review)]

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

mb/google/dedede: add mainboard_smi_espi_handler for dedede.

By adding mainboard_smi_espi_handler, the lid close smi can be handled
properly.

BUG=b:163382105

Signed-off-by: Kane Chen 
Change-Id: I8a2ecb52d5f6586f8acd57c4965b4238b95e3b64
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44564/1

diff --git a/src/mainboard/google/dedede/smihandler.c b/src/mainboard/google/dedede/smihandler.c
index 0254810..20f0207 100644
--- a/src/mainboard/google/dedede/smihandler.c
+++ b/src/mainboard/google/dedede/smihandler.c
@@ -36,3 +36,8 @@
 {
    google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS);
 }
+
+void mainboard_smi_espi_handler(void)
+{
+	chromeec_smi_process_events();
+}

[Kane Chen (Code Review)]

Kane Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

mb/google/dedede: add mainboard_smi_espi_handler for dedede.

By adding mainboard_smi_espi_handler, the lid close smi can be handled
properly.

BUG=b:163382105

Signed-off-by: Kane Chen 
Change-Id: I8a2ecb52d5f6586f8acd57c4965b4238b95e3b64
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44564/2

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 3: Code-Review+1

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44564/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44564/3//COMMIT_MSG@9 
PS3, Line 9: the lid close smi can be handled
           : properly
Can be moved to TEST=

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 3: Code-Review+2

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 4: Code-Review+2

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 4:

could we merge this?
thanks

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44564/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44564/3//COMMIT_MSG@9 
PS3, Line 9: the lid close smi can be handled
           : properly
> Can be moved to TEST=

Done

[Kane Chen (Code Review)]

Hello build bot (Jenkins), Dtrain Hsu, Maulik V Vaghela, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44564

to look at the new patch set (#5).

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

mb/google/dedede: add mainboard_smi_espi_handler for dedede.

By adding mainboard_smi_espi_handler, the espi smi can be handled
properly.

BUG=b:163382105
TEST=The lid close smi can be handled properly.

Signed-off-by: Kane Chen 
Change-Id: I8a2ecb52d5f6586f8acd57c4965b4238b95e3b64
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44564/5

[Kane Chen (Code Review)]

Hello build bot (Jenkins), Dtrain Hsu, Maulik V Vaghela, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44564

to look at the new patch set (#6).

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

mb/google/dedede: add mainboard_smi_espi_handler for dedede.

By adding mainboard_smi_espi_handler, the espi smi can be handled
properly.

BUG=b:163382105
TEST=Tested lid close smi can be handled properly in depthcharge stage

Signed-off-by: Kane Chen 
Change-Id: I8a2ecb52d5f6586f8acd57c4965b4238b95e3b64
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44564/6

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

Patch Set 6: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44564 )

Change subject: mb/google/dedede: add mainboard_smi_espi_handler for dedede.
......................................................................

mb/google/dedede: add mainboard_smi_espi_handler for dedede.

By adding mainboard_smi_espi_handler, the espi smi can be handled
properly.

BUG=b:163382105
TEST=Tested lid close smi can be handled properly in depthcharge stage

Signed-off-by: Kane Chen 
Change-Id: I8a2ecb52d5f6586f8acd57c4965b4238b95e3b64
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44564
Reviewed-by: Subrata Banik 
Reviewed-by: Maulik V Vaghela 
Reviewed-by: Dtrain Hsu 
Reviewed-by: Aamir Bohra 
Reviewed-by: Karthik Ramasubramanian 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Subrata Banik: Looks good to me, approved
  Aamir Bohra: Looks good to me, approved
  Maulik V Vaghela: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Dtrain Hsu: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/smihandler.c b/src/mainboard/google/dedede/smihandler.c
index 0254810..20f0207 100644
--- a/src/mainboard/google/dedede/smihandler.c
+++ b/src/mainboard/google/dedede/smihandler.c
@@ -36,3 +36,8 @@
 {
    google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS);
 }
+
+void mainboard_smi_espi_handler(void)
+{
+	chromeec_smi_process_events();
+}