Attention is currently required from: Benjamin Doron, David Milosevic, Patrick Rudolph.
Arthur Heymans has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/79108?usp=email )
Change subject: mb/emulation/qemu-sbsa: Generate PPTT ACPI table ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/emulation/qemu-sbsa/pptt.c:
https://review.coreboot.org/c/coreboot/+/79108/comment/d1305844_bd96afed?usp... : PS7, Line 9: #define CACHE_NODE_FLAGS 0xd7 // everything valid except, write-policy and allocation type : #define CLUSTER_FLAGS 0x11 // physical package, ID invalid, no thread, no leaf, identical impl. : #define CORE_FLAGS 0x1a // no physical package, ID valid, no thread, leaf, identical impl. : : #define CACHE_ATTR_TYPE_DATA (0) : #define CACHE_ATTR_TYPE_INSTRUCTION (0x1 << 2) : #define CACHE_ATTR_TYPE_UNIFIED (0x1 << 3)
Done
You have a struct for the pptt_cache flags. Why use a raw value?
const struct pptt_cache_node_flags cache_flags = { .size_valid = 1, .n_sets_valid = 1, ... };
Same for the cpu flags.