Attention is currently required from: CoolStar, Martin Roth, Matt DeVillier, Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )
Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/link/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/76159/comment/715938d5_793c0c23 :
PS1, Line 14: // Trackpad Wake is GPIO12
: Name(_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x03 } )
:
well, there's no reason to make it either-or, since the two coexist without issue. […]
Okay, well then I didn't say anything 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7ee05d15bc17d335cf8c1a8e80bea62800de475
Gerrit-Change-Number: 76159
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 22:08:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment