Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83513?usp=email )
Change subject: device/pci_ids: Add new Intel PTL device IDs for XHCI/TCSS XHCI ......................................................................
device/pci_ids: Add new Intel PTL device IDs for XHCI/TCSS XHCI
This patch adds new XHCI/TCSS XHCI PCI device IDs for Intel PTL-U and PTL-H.
Additionally, updates the XHCI driver's `pci_device_ids` list to include these new IDs.
Source: Intel PTL-EDS vol 1. Document Number 815002, Rev 0.51 Chapter 2
BUG=b:347669091 TEST=Able to build google/fatcat.
Change-Id: I5ae8f493374087a5e684e0a04486cd64cea6f335 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83513 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pci_ids.h M src/soc/intel/common/block/usb4/xhci.c M src/soc/intel/common/block/xhci/xhci.c 3 files changed, 8 insertions(+), 4 deletions(-)
Approvals: Eric Lai: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 4674f7b..5fa478f 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -4498,8 +4498,10 @@ #define PCI_DID_INTEL_RPP_S_XHCI 0x7a60 #define PCI_DID_INTEL_LNL_XHCI 0xa87d #define PCI_DID_INTEL_LNL_TCSS_XHCI 0xa831 -#define PCI_DID_INTEL_PTL_XHCI 0xe47d -#define PCI_DID_INTEL_PTL_TCSS_XHCI 0xe431 +#define PCI_DID_INTEL_PTL_H_XHCI 0xe47d +#define PCI_DID_INTEL_PTL_H_TCSS_XHCI 0xe431 +#define PCI_DID_INTEL_PTL_U_H_XHCI 0xe37d +#define PCI_DID_INTEL_PTL_U_H_TCSS_XHCI 0xe331
/* Intel P2SB device Ids */ #define PCI_DID_INTEL_APL_P2SB 0x5a92 diff --git a/src/soc/intel/common/block/usb4/xhci.c b/src/soc/intel/common/block/usb4/xhci.c index 4e1a2a8..8776e4d 100644 --- a/src/soc/intel/common/block/usb4/xhci.c +++ b/src/soc/intel/common/block/usb4/xhci.c @@ -26,7 +26,8 @@ };
static const unsigned short pci_device_ids[] = { - PCI_DID_INTEL_PTL_TCSS_XHCI, + PCI_DID_INTEL_PTL_H_TCSS_XHCI, + PCI_DID_INTEL_PTL_U_H_TCSS_XHCI, PCI_DID_INTEL_LNL_TCSS_XHCI, PCI_DID_INTEL_RPP_P_TCSS_XHCI, PCI_DID_INTEL_MTL_M_TCSS_XHCI, diff --git a/src/soc/intel/common/block/xhci/xhci.c b/src/soc/intel/common/block/xhci/xhci.c index dd4e5de..c1f300a 100644 --- a/src/soc/intel/common/block/xhci/xhci.c +++ b/src/soc/intel/common/block/xhci/xhci.c @@ -131,7 +131,8 @@ };
static const unsigned short pci_device_ids[] = { - PCI_DID_INTEL_PTL_XHCI, + PCI_DID_INTEL_PTL_H_XHCI, + PCI_DID_INTEL_PTL_U_H_XHCI, PCI_DID_INTEL_LNL_XHCI, PCI_DID_INTEL_MTL_XHCI, PCI_DID_INTEL_APL_XHCI,