Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85630?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver ......................................................................
Patch Set 7:
(8 comments)
File src/soc/mediatek/common/mt6316.c:
https://review.coreboot.org/c/coreboot/+/85630/comment/151a649d_0b20fb0a?usp... : PS7, Line 48: 0x%x %#x
https://review.coreboot.org/c/coreboot/+/85630/comment/ac75140a_679f53b0?usp... : PS7, Line 78: %u `%u\n`
https://review.coreboot.org/c/coreboot/+/85630/comment/d7a352cc_65ae76b3?usp... : PS7, Line 106: %u \n
https://review.coreboot.org/c/coreboot/+/85630/comment/7cb4d82f_d9aa2d12?usp... : PS7, Line 132: %u `%u\n`
https://review.coreboot.org/c/coreboot/+/85630/comment/ec1a747a_99dfff01?usp... : PS7, Line 158: -1 false
https://review.coreboot.org/c/coreboot/+/85630/comment/b55b1b50_3d2a7c3c?usp... : PS7, Line 170: { remove
https://review.coreboot.org/c/coreboot/+/85630/comment/9e0760da_af457720?usp... : PS7, Line 184: : printk(BIOS_INFO, "[%s][MT6316_6]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_6, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); : printk(BIOS_INFO, "[%s][MT6316_7]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_7, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); : printk(BIOS_INFO, "[%s][MT6316_8]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_8, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); : printk(BIOS_INFO, "[%s][MT6316_15]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_15, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); ``` for (int i = 0; i < ARRAY_SIZE(mt6316_slave_id); i++) printk(BIOS_INOF, "%s: MT6316_%d: CHIP ID = %#x", __func__, mt6316_slave_id[i] mt6316_read_field(mt6316_slave_id[i], MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0));); ```
https://review.coreboot.org/c/coreboot/+/85630/comment/6eaedc9d_70d1e469?usp... : PS7, Line 199: { remove