Attention is currently required from: Anil Kumar K, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62192 )
Change subject: soc/intel/common: Retry END_OF_POST command ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62192/comment/c5fd7e07_8e4c5fee PS6, Line 11: max 3 times before triggering the error handling flow.
What is the problem, and why is the retry needed? Why three and not less or more?
Since EOP command is critical to maintain platform security, so retries are recommended by Intel CSE BIOS Spec for certain scenarios (no response message within 5 seconds or received garbled message).
Patchset:
PS6:
Are new debug messages printed?
Sorry, I didn't get. I didn't add any debug messages in this patch.
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/62192/comment/fcb72b95_fd159113 PS6, Line 55: case CSE_TX_ERR_CSE_NOT_READY:
Does this need fallthrough statements? Does clang build the image without problems?
Yes, I didn't notice any issues.
-
Sridhar Siricilla (Code Review)