Change in ...coreboot[master]: Add missing u8 eos[2] declaration to struct smbios_type38
Łukasz Siudut has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31482
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Add missing u8 eos[2] declaration to struct smbios_type38
Each smbios should be followed with two null bytes. In other structures it's done by adding `u8 eos[2]` extra bytes at the end, it was omitted in type38 (IPMI) though. This change fixes this - tables decodes nicely:
``` IPMI Device Information Interface Type: KCS (Keyboard Control Style) Specification Version: 2.0 I2C Slave Address: 0x10 NV Storage Device: Not Present Base Address: 0x0000000000000CA2 (I/O) Register Spacing: 32-bit Boundaries ```
This is follow up of change #31435
Signed-off-by: Lukasz Siudut lsiudut@fb.com Change-Id: I8efea9612448f48e23e7b2226aea2a9f3bc21824 --- M src/include/smbios.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/31482/1
diff --git a/src/include/smbios.h b/src/include/smbios.h index 38ebcdc..c046b1a 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -493,6 +493,7 @@ u64 base_address; u8 base_address_modifier; u8 irq; + u8 eos[2]; } __packed;
enum smbios_bmc_interface_type {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31482 )
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31482/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31482/1//COMMIT_MSG@9 PS1, Line 9: smbios SMBIOS entry?
https://review.coreboot.org/#/c/31482/1//COMMIT_MSG@23 PS1, Line 23: This is follow up of change #31435 This line can be removed in my opinion.
https://review.coreboot.org/#/c/31482/1//COMMIT_MSG@23 PS1, Line 23: follow up follow-up
Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31482
to look at the new patch set (#2).
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Add missing u8 eos[2] declaration to struct smbios_type38
Each smbios entry should be followed with two null bytes. In other structures it's done by adding `u8 eos[2]` extra bytes at the end, it was omitted in type38 (IPMI) though. This change fixes this - tables decodes nicely:
``` IPMI Device Information Interface Type: KCS (Keyboard Control Style) Specification Version: 2.0 I2C Slave Address: 0x10 NV Storage Device: Not Present Base Address: 0x0000000000000CA2 (I/O) Register Spacing: 32-bit Boundaries ```
Signed-off-by: Lukasz Siudut lsiudut@fb.com Change-Id: I8efea9612448f48e23e7b2226aea2a9f3bc21824 --- M src/include/smbios.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/31482/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31482 )
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Patch Set 2: Code-Review+1
Looks good with the nits fixed.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31482 )
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31482 )
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31482 )
Change subject: Add missing u8 eos[2] declaration to struct smbios_type38 ......................................................................
Add missing u8 eos[2] declaration to struct smbios_type38
Each smbios entry should be followed with two null bytes. In other structures it's done by adding `u8 eos[2]` extra bytes at the end, it was omitted in type38 (IPMI) though. This change fixes this - tables decodes nicely:
``` IPMI Device Information Interface Type: KCS (Keyboard Control Style) Specification Version: 2.0 I2C Slave Address: 0x10 NV Storage Device: Not Present Base Address: 0x0000000000000CA2 (I/O) Register Spacing: 32-bit Boundaries ```
Signed-off-by: Lukasz Siudut lsiudut@fb.com Change-Id: I8efea9612448f48e23e7b2226aea2a9f3bc21824 Reviewed-on: https://review.coreboot.org/c/31482 Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/smbios.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, but someone else must approve
diff --git a/src/include/smbios.h b/src/include/smbios.h index 38ebcdc..c046b1a 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -493,6 +493,7 @@ u64 base_address; u8 base_address_modifier; u8 irq; + u8 eos[2]; } __packed;
enum smbios_bmc_interface_type {
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Łukasz Siudut (Code Review)