Change in ...coreboot[master]: mb/google/octopus: Add keyboard backlight support for bloog
Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31981
Change subject: mb/google/octopus: Add keyboard backlight support for bloog ......................................................................
mb/google/octopus: Add keyboard backlight support for bloog
Bloog supports keyboard backlight feature, so enable the ASL code.
BUG=b:127736039 BRANCH=octopus TEST=Build and boot bloog, verify that the string 'KBLT' is in the DSDT.
Change-Id: Iba66aade090816ea2376cae4baf4aae019cc97f4 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/include/variant/ec.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/31981/1
diff --git a/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h b/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h index 260d7d4..368413a 100644 --- a/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h @@ -18,4 +18,6 @@
#include <baseboard/ec.h>
+#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
Hello Wisley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31981
to look at the new patch set (#2).
Change subject: mb/google/octopus: Add keyboard backlight support for bloog ......................................................................
mb/google/octopus: Add keyboard backlight support for bloog
Bloog supports keyboard backlight feature, so enable the ASL code.
BUG=b:127736039 BRANCH=octopus TEST=Build and boot bloog, verify that the string 'KBLT' is in the DSDT.
Change-Id: Iba66aade090816ea2376cae4baf4aae019cc97f4 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/31981/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31981 )
Change subject: mb/google/octopus: Add keyboard backlight support for bloog ......................................................................
Patch Set 2: Code-Review+2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31981 )
Change subject: mb/google/octopus: Add keyboard backlight support for bloog ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31981 )
Change subject: mb/google/octopus: Add keyboard backlight support for bloog ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31981 )
Change subject: mb/google/octopus: Add keyboard backlight support for bloog ......................................................................
mb/google/octopus: Add keyboard backlight support for bloog
Bloog supports keyboard backlight feature, so enable the ASL code.
BUG=b:127736039 BRANCH=octopus TEST=Build and boot bloog, verify that the string 'KBLT' is in the DSDT.
Change-Id: Iba66aade090816ea2376cae4baf4aae019cc97f4 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31981 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/bloog/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h b/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h index 260d7d4..feb6c71 100644 --- a/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h @@ -18,4 +18,7 @@
#include <baseboard/ec.h>
+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
-
Furquan Shaikh (Code Review) -
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Tony Huang (Code Review)