Hello Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/33364
to review the following change.
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
mb/lenovo/z61t: Remove `fn_ctrl_swap` option
It seems that the EC on t60/x60 and modifications doesn't support it. This wasn't even introduced in z61t so let's remove the remaining bits.
This commit follows up on commit a5fcc2e4 with Change-Id Id2964002406a5fcf992f0ffc3627e3f66a2bb13f ("mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option").
Untested.
Change-Id: Ifd5e7823af305cc4a0194ee2097a749e43680c55 Signed-off-by: Nico Huber nico.huber@secunet.com Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/z61t/cmos.layout 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33364/1
diff --git a/src/mainboard/lenovo/z61t/cmos.layout b/src/mainboard/lenovo/z61t/cmos.layout index b9e2b44..75ad427 100644 --- a/src/mainboard/lenovo/z61t/cmos.layout +++ b/src/mainboard/lenovo/z61t/cmos.layout @@ -78,7 +78,7 @@ 952 8 h 0 volume 960 1 e 9 first_battery 961 1 e 1 trackpoint -962 1 e 1 fn_ctrl_swap +#962 1 r 0 unused 963 1 e 1 sticky_fn 964 1 e 1 power_management_beeps 965 1 e 1 low_battery_beep
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33364 )
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
Patch Set 1:
Is there any reference that says its using the same EC firmware as X60/T60? Or maybe something that tells us if the option is present on T/X61?
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33364 )
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
Patch Set 1:
Patch Set 1:
Is there any reference that says its using the same EC firmware as X60/T60? Or maybe something that tells us if the option is present on T/X61?
I've asked an owner for the confirmation. I'll remove "Untested" as soon as a hear from this person. However I decided to publish it anyway just in case if anyone else can confirm/deny it .
Peter Lemenkov has removed a vote on this change.
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
Removed Code-Review+2 by Peter Lemenkov lemenkov@gmail.com
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33364
to look at the new patch set (#4).
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
mb/lenovo/z61t: Remove `fn_ctrl_swap` option
It seems that the EC on t60/x60/z61t doesn't support it. This wasn't even introduced in z61t so let's remove the remaining bits.
This commit follows up on commit a5fcc2e4 with Change-Id Id2964002406a5fcf992f0ffc3627e3f66a2bb13f ("mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option").
Tested on a real hardware.
Change-Id: Ifd5e7823af305cc4a0194ee2097a749e43680c55 Signed-off-by: Nico Huber nico.huber@secunet.com Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/z61t/cmos.layout 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33364/4
Andrey Korolyov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33364 )
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
Patch Set 3: Code-Review+1
The fn-swap option isn't available on z61t yet, right.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33364 )
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33364 )
Change subject: mb/lenovo/z61t: Remove `fn_ctrl_swap` option ......................................................................
mb/lenovo/z61t: Remove `fn_ctrl_swap` option
It seems that the EC on t60/x60/z61t doesn't support it. This wasn't even introduced in z61t so let's remove the remaining bits.
This commit follows up on commit a5fcc2e4 with Change-Id Id2964002406a5fcf992f0ffc3627e3f66a2bb13f ("mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option").
Tested on a real hardware.
Change-Id: Ifd5e7823af305cc4a0194ee2097a749e43680c55 Signed-off-by: Nico Huber nico.huber@secunet.com Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33364 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Andrey Korolyov andrey@xdel.ru --- M src/mainboard/lenovo/z61t/cmos.layout 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Andrey Korolyov: Looks good to me, but someone else must approve
diff --git a/src/mainboard/lenovo/z61t/cmos.layout b/src/mainboard/lenovo/z61t/cmos.layout index b9e2b44..75ad427 100644 --- a/src/mainboard/lenovo/z61t/cmos.layout +++ b/src/mainboard/lenovo/z61t/cmos.layout @@ -78,7 +78,7 @@ 952 8 h 0 volume 960 1 e 9 first_battery 961 1 e 1 trackpoint -962 1 e 1 fn_ctrl_swap +#962 1 r 0 unused 963 1 e 1 sticky_fn 964 1 e 1 power_management_beeps 965 1 e 1 low_battery_beep
-
Andrey Korolyov (Code Review) -
Nico Huber (Code Review)
-
Peter Lemenkov (Code Review)