Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Paul Menzel, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 )
Change subject: amdfwtool: Add --fsp-version option ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74266/comment/7fcaea9c_4b9d2e15 PS1, Line 9: This version tells amdfwtool to create a text file : which contains versions of following blobs: : PSP bootloader (type 0x01), : SMU firmware (type 0x08), : AGESA bootloader 0 (type 0x30).
Passing this option tells amdfwtool to create a text file, […]
OK, I rephrase according to requested changes.
https://review.coreboot.org/c/coreboot/+/74266/comment/309c63d7_bb0f6d98 PS1, Line 14:
What is the new switch/option going to be used for? Maybe start with the motivation.
Sure, I'll add it
https://review.coreboot.org/c/coreboot/+/74266/comment/528d0736_63087d50 PS1, Line 16: TEST=Tested on Skyrim device
If possible, please paste the commands and the output: […]
Yes, I'll add it in the next version
Patchset:
PS1:
As I do not know, what the option is going to be used for, I think the KISS way would be to just out […]
No problem, I will print the versions to the standard out. What do you think about --print-type0x01-version, --print-type0x08-version and so on?
-
Grzegorz Bernacki (Code Review)