Attention is currently required from: Bernardo Perez Priego, Jamie Ryu, Jay Patel, Kapil Porwal, Li1 Feng, Tarun Tuli, Wonkyu Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
......................................................................
Patch Set 8: Code-Review-1
(2 comments)
Patchset:
PS8:
i don't kw what is the board version that being looked at here
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/75525/comment/c9eb05ca_ef000d07 :
PS8, Line 98: if (google_chromeec_cbi_get_board_version(&board_version)) {
: printk(BIOS_ERR,
: "Unable to get Board Version for ISH.\n");
: return;
: }
what is this board version ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75525?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0f9a7c8318fa9ae59b6f613eafdacbfa07c749
Gerrit-Change-Number: 75525
Gerrit-PatchSet: 8
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jay Patel
jay2.patel@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jay Patel
jay2.patel@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 09:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment