Attention is currently required from: Angel Pons.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83093?usp=email )
Change subject: mb/gigabyte/ga-h61m-series: Make use of device alias names in dt ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/gigabyte/ga-h61m-series/variants/ga-h61m-ds2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83093/comment/194018fd_0ed3ea9c?usp... : PS2, Line 10: : device ref pcie_rp2 on end # x1 Port (PCIEX1_1) : device ref pcie_rp3 off end : device ref pcie_rp4 off end : device ref pcie_rp5 on end # Realtek RTL8111F GbE NIC : device ref pcie_rp6 on end # x1 Port (PCIEX1_2)
"x1 Port" doesn't specify the form factor. It could be mPCIe for all that matters. […]
Good point. Fix applied.
File src/mainboard/gigabyte/ga-h61m-series/variants/ga-h61m-ds2v/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83093/comment/3c1b2f6f_ff0db03c?usp... : PS2, Line 8: : device ref pcie_rp2 on end # x1 Port (PCIEX1_1) : device ref pcie_rp3 off end : device ref pcie_rp4 off end : device ref pcie_rp5 on end # Realtek RTL8111F GbE NIC : device ref pcie_rp6 on end # x1 Port (PCIEX1_2)
Good point. Fix applied.
File src/mainboard/gigabyte/ga-h61m-series/variants/ga-h61m-s2pv/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83093/comment/814b396f_0fbd0254?usp... : PS2, Line 8: device ref pcie_rp1 on end # x1 Port (PCIEX1)
Good point. Fix applied.
File src/mainboard/gigabyte/ga-h61m-series/variants/ga-h61ma-d3v/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83093/comment/0277b56c_637e174a?usp... : PS2, Line 8: : device ref pcie_rp2 on end # x1 Port (PCIEX1_1) : device ref pcie_rp3 on end # Etron EJ168 USB 3.0 : device ref pcie_rp4 on end # Marvell 88SE9172 SATA : device ref pcie_rp5 on end # Realtek RTL8111F GbE NIC : device ref pcie_rp6 on end # x1 Port (PCIEX1_2)
Good point. Fix applied.