Attention is currently required from: Kane Chen, Paul Menzel.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62919 )
Change subject: soc/intel/{adl,common}: Add ASPM setting in pcie_rp_config
......................................................................
Patch Set 17:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62919/comment/35c2ffdc_9f8d82c4
PS16, Line 7: soc/intel/{adl,common}: Add ASPM setting in pcie_rp_config.
Please remove the dot/period at the end [1]. […]
Updated in latest patch.
https://review.coreboot.org/c/coreboot/+/62919/comment/d7223f45_1ccea3c3
PS16, Line 12: TEST=Build FW and run stress exceed 2500 cycles.
On what system?
Updated in latest patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19b5f3dc8d95e153301d777492c921ce582ba988
Gerrit-Change-Number: 62919
Gerrit-PatchSet: 17
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Martin L Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 04:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment