Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76014?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for ScsEmmcHs400Enabled dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for ScsEmmcHs400Enabled dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="ScsEmmcHs400Enabled" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Idcf53179196ea65f81babfeb5fdd9157ca35362e Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb M src/mainboard/google/hatch/variants/kindred/overridetree.cb M src/mainboard/google/hatch/variants/nightfury/overridetree.cb M src/mainboard/google/puff/variants/ambassador/overridetree.cb M src/mainboard/google/puff/variants/dooly/overridetree.cb M src/mainboard/google/puff/variants/duffy/overridetree.cb M src/mainboard/google/puff/variants/faffy/overridetree.cb M src/mainboard/google/puff/variants/genesis/overridetree.cb M src/mainboard/google/puff/variants/kaisa/overridetree.cb M src/mainboard/google/puff/variants/moonbuggy/overridetree.cb M src/mainboard/google/puff/variants/noibat/overridetree.cb M src/mainboard/google/puff/variants/puff/overridetree.cb M src/mainboard/google/puff/variants/scout/overridetree.cb M src/mainboard/google/puff/variants/wyvern/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb M src/mainboard/protectli/vault_cml/devicetree.cb 18 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/76014/1
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 0aefc5e..56a3088 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -69,7 +69,7 @@ register "sdcard_cd_gpio" = "vSD3_CD_B"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
device domain 0 on device pci 02.0 on # Integrated Graphics Device diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 66f2b81..4eb2970 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -66,7 +66,7 @@ register "sdcard_cd_gpio" = "vSD3_CD_B"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
device domain 0 on device pci 02.0 on # Integrated Graphics Device diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index 8d5ccaf..a98651f 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -66,7 +66,7 @@ register "sdcard_cd_gpio" = "vSD3_CD_B"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
device domain 0 on device pci 02.0 on diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index a2c9322..ffa28ae 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -57,7 +57,7 @@ register "sdcard_cd_gpio" = "vSD3_CD_B"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb index 12de513..6ff9b64 100644 --- a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb +++ b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb @@ -73,7 +73,7 @@ register "sdcard_cd_gpio" = "vSD3_CD_B"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/ambassador/overridetree.cb b/src/mainboard/google/puff/variants/ambassador/overridetree.cb index 052e832..c3fd102 100644 --- a/src/mainboard/google/puff/variants/ambassador/overridetree.cb +++ b/src/mainboard/google/puff/variants/ambassador/overridetree.cb @@ -98,7 +98,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/dooly/overridetree.cb b/src/mainboard/google/puff/variants/dooly/overridetree.cb index a5cf3ba..bcc98e4 100644 --- a/src/mainboard/google/puff/variants/dooly/overridetree.cb +++ b/src/mainboard/google/puff/variants/dooly/overridetree.cb @@ -85,7 +85,7 @@ USB_PORT_WAKE_ENABLE(2)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/duffy/overridetree.cb b/src/mainboard/google/puff/variants/duffy/overridetree.cb index 54f661c..4b0cabc 100644 --- a/src/mainboard/google/puff/variants/duffy/overridetree.cb +++ b/src/mainboard/google/puff/variants/duffy/overridetree.cb @@ -159,7 +159,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/faffy/overridetree.cb b/src/mainboard/google/puff/variants/faffy/overridetree.cb index 0cde491..8157bb5 100644 --- a/src/mainboard/google/puff/variants/faffy/overridetree.cb +++ b/src/mainboard/google/puff/variants/faffy/overridetree.cb @@ -167,7 +167,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/genesis/overridetree.cb b/src/mainboard/google/puff/variants/genesis/overridetree.cb index 694527c..07f7f28 100644 --- a/src/mainboard/google/puff/variants/genesis/overridetree.cb +++ b/src/mainboard/google/puff/variants/genesis/overridetree.cb @@ -91,7 +91,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/kaisa/overridetree.cb b/src/mainboard/google/puff/variants/kaisa/overridetree.cb index 946678d..c07a1e9 100644 --- a/src/mainboard/google/puff/variants/kaisa/overridetree.cb +++ b/src/mainboard/google/puff/variants/kaisa/overridetree.cb @@ -159,7 +159,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb index 1a2c720..4649b96 100644 --- a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb +++ b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb @@ -91,7 +91,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/noibat/overridetree.cb b/src/mainboard/google/puff/variants/noibat/overridetree.cb index d7492ff..687d226 100644 --- a/src/mainboard/google/puff/variants/noibat/overridetree.cb +++ b/src/mainboard/google/puff/variants/noibat/overridetree.cb @@ -82,7 +82,7 @@ USB_PORT_WAKE_ENABLE(5)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/puff/overridetree.cb b/src/mainboard/google/puff/variants/puff/overridetree.cb index ab8236b..a1b7cd4 100644 --- a/src/mainboard/google/puff/variants/puff/overridetree.cb +++ b/src/mainboard/google/puff/variants/puff/overridetree.cb @@ -92,7 +92,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/scout/overridetree.cb b/src/mainboard/google/puff/variants/scout/overridetree.cb index d5393d1..e027589 100644 --- a/src/mainboard/google/puff/variants/scout/overridetree.cb +++ b/src/mainboard/google/puff/variants/scout/overridetree.cb @@ -98,7 +98,7 @@ USB_PORT_WAKE_ENABLE(6)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/google/puff/variants/wyvern/overridetree.cb b/src/mainboard/google/puff/variants/wyvern/overridetree.cb index 4065d6e..2272a06 100644 --- a/src/mainboard/google/puff/variants/wyvern/overridetree.cb +++ b/src/mainboard/google/puff/variants/wyvern/overridetree.cb @@ -93,7 +93,7 @@ USB_PORT_WAKE_ENABLE(5)"
# Enable eMMC HS400 - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# EMMC Tx CMD Delay # Refer to EDS-Vol2-14.3.7. diff --git a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb index 76f62fc..7c1fb74 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb @@ -4,7 +4,7 @@
# FSP configuration register "SaGv" = "SaGv_Enabled" - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" register "usb2_ports[1]" = "USB2_PORT_MID(OC0)" diff --git a/src/mainboard/protectli/vault_cml/devicetree.cb b/src/mainboard/protectli/vault_cml/devicetree.cb index 0d6cbd4..3a22ed0 100644 --- a/src/mainboard/protectli/vault_cml/devicetree.cb +++ b/src/mainboard/protectli/vault_cml/devicetree.cb @@ -17,7 +17,7 @@
# FSP configuration register "SaGv" = "SaGv_Enabled" - register "ScsEmmcHs400Enabled" = "1" + register ScsEmmcHs400Enabled = true
# Enable eDP device register "DdiPortEdp" = "1" # Display Port