[S] Change in coreboot[main]: mb/system76/mtl: darp10: Add TCSS configs - coreboot-gerrit

31 Jul 2024


      Attention is currently required from: Jeremy Soller, Tim Crawford.
Paul Menzel has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/83696?usp=email )
Change subject: mb/system76/mtl: darp10: Add TCSS configs
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83696/comment/a8453bbe_751f9f44?usp... :
PS1, Line 10: 
Any other log messages from Linux or so?
File src/mainboard/system76/mtl/variants/darp10/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83696/comment/56f2bce1_b70513d0?usp... :
PS1, Line 10: BIT 6 is orientational
So it’s 0 below in 0x82. What orientation is it?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83696?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9bc6c5fc4c13bfa2e31ee1ce334b91e151373b6e
Gerrit-Change-Number: 83696
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Comment-Date: Wed, 31 Jul 2024 09:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No