Attention is currently required from: Angel Pons, Martin L Roth, Maximilian Brune.
Arthur Heymans has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email )
Change subject: treewide: Add generation of CFR Tables
......................................................................
Patch Set 7:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/82494/comment/f82fdd23_75be1790?usp... :
PS7, Line 568: __weak
why weak?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82494?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133
Gerrit-Change-Number: 82494
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 13:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No