Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 28:
(7 comments)
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/11e1861a_0747d0e9 PS28, Line 247: { NULL, ITE_SMFI, PNP_IRQ0, 0xfff0, }, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/290850a6_47d2248a PS28, Line 250: /* Power Mangement I/F Channel 1 (PMC1) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/14a86c35_500aab99 PS28, Line 252: /* Power Mangement I/F Channel 2 (PMC2) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/55724ee9_514cd7e2 PS28, Line 258: /* Power Mangement I/F Channel 3 (PMC3) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/8e81fa1f_8af8c063 PS28, Line 260: /* Power Mangement I/F Channel 4 (PMC4) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/f252fcad_c76e2dce PS28, Line 262: /* Power Mangement I/F Channel 5 (PMC5) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133009): https://review.coreboot.org/c/coreboot/+/58343/comment/f71c9b30_66f9dde9 PS28, Line 274: }; adding a line without newline at end of file
-
build bot (Jenkins) (Code Review)